Codecov Report

Merging #2844 (45ac10f) into main (8182dab) will increase coverage by 1.32%.
The diff coverage is n/a.

❗ Current head 45ac10f differs from pull request most recent head 9745804. Consider uploading reports for the commit 9745804 to get more accurate results

@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
+ Coverage   93.52%   94.85%   +1.32%     
==========================================
  Files         163       16     -147     
  Lines        5572      602    -4970     
  Branches     1180      107    -1073     
==========================================
- Hits         5211      571    -4640     
+ Misses        361       31     -330     

The test is failing. It seems like the gcp-detector is not behaving in an expected way...

Well, it seems the problem is related to @opentelemetry/api version mismatch: @opentelemetry/sdk-node uses ~1.0.3, whilst @opentelemetry/resource-detector-gcp uses v1.1.0 (^1.0.2)

I think we might consider moving the sdk node to the contrib since all detectors live there

I believe we'll need a version bump on dependencies of experimental packages to get the CI working.

Edit: well, no need to do so. We have only @opentelemetry/sdk-node that uses ~1.0.3 notation on @opentelemetry/api.

@Flarna What is the main difference between compile and publishOnly script?

The publishOnly is an npm hook that is executed before the npm publish command (See https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-operation-order for more details), while compile is not an npm hooks.

I'd wait for @dyladan 's opinion on this since he is the one who performs the releases.

Isn't it prepublishOnly?

@Flarna thank you for pointing that out! That was a silly mistake I've made :(

I'd wait for @dyladan 's opinion on this since he is the one who performs the releases.

I'm working locally on a branch to automate the releases as I don't want to do it forever